Use pydantic for cache entries and hits #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles 2 things:
Uses pydantic for both
CacheEntry
andCacheHit
models. It ended up being better and cleaner to have two separate models.... one for what we write, and the other for what we load.Filtering. @justin-cechmanek I want your feedback on this. I landed on a technique to allow for the user to define a list of
filterable_fields
as part of the semantic cache class init. What this does is give us a way to support arbitrary filters (scope, permissions, tags, numerics.... anything) within reason. Then you can create anyFilterExpression
and pass through at query time. This extends your initial implementation.